kosiew commented on code in PR #24969:
URL: https://github.com/apache/datafusion/pull/24969#discussion_r3957545496
##########
datafusion/core/src/datasource/memory_test.rs:
##########
@@ -479,6 +489,81 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn test_insert_overwrite_replaces_existing_data() -> Result<()> {
Review Comment:
Could we add an overwrite test with multiple target partitions and multiple
input batches? The current tests cover a single target partition, while
`MemSink::write_all` distributes batches round-robin and then replaces each
target partition independently. A test that asserts every partition contains
only its replacement batches would give us coverage for the full overwrite loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
