emilk opened a new pull request, #25080:
URL: https://github.com/apache/datafusion/pull/25080
## Which issue does this PR close?
- Part of #18467.
## Rationale for this change
Part 2 of 3, split out of #24848. Stacked on part 1, so review that first:
- PR1LINK
- PR3LINK
Turn on more `clippy::pedantic` lints from the opt-out list in `Cargo.toml`.
## What changes are included in this PR?
One commit per lint, each removing its `"allow"` line from `Cargo.toml` and
fixing every site. Review one commit at a time!
Let me know if you disagree with any and I'll revert it.
| Lint
| Sites | Fix
|
|
-------------------------------------------------------------------------------------------------------------
| ----: | ------------------------------------------------------------------ |
|
[`unnested_or_patterns`](https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns)
| 68 | `Time32(Microsecond \| Nanosecond)` instead of repeating the
prefix |
|
[`match_bool`](https://rust-lang.github.io/rust-clippy/master/index.html#match_bool)
| 46 | `if`/`else` instead of `match` on a bool
|
|
[`missing_fields_in_debug`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug)
| 29 | `finish_non_exhaustive()` on manual `Debug` impls that skip a field |
## What is the testing strategy for this PR?
Clippy is clean both with `--all-features` and with default features. The
changes are mechanical, so no new tests.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
