andygrove commented on PR #5763: URL: https://github.com/apache/datafusion-comet/pull/5763#issuecomment-5588455302
Path escaping is fixed in d36ad9f, in both serdes — the 3.x one had the same `URI.create` call, where the enclosing catch turned it into a silent fallback instead of a query failure. The new test isn't version-gated and I confirmed it fails both ways without the fix. I also took your point on the INSERT visibility test: it now captures the executed plan and asserts a native write, so a fallback can't make the read-back pass for the wrong reason. On `recordRows`, agreed there's no measured number here and I'm not claiming one. Speculative concurrent attempts are still untested — the attempt path is Spark's own `newTaskTempFile`, but I'd rather say that's unverified than imply otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
