Rachelint commented on PR #11943: URL: https://github.com/apache/datafusion/pull/11943#issuecomment-2299246837
> I ran the benchmarks on my test machine and I see similar results > > Overall things get significantly better but a few get slower (e.g. `Q37`) but I suspect we can figure out how to resolve those regressions > > Nice work @Rachelint > Details @Dandandan pointed out that many unnecessary `mode check` and `self.counts.current_mut().unwrap()` exists in `accumulate_indices`. And I found the all of q22, q36, q37 will go this path, it is possible the reason why they get slower. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
