sam-1112 commented on PR #5415: URL: https://github.com/apache/datafusion-comet/pull/5415#issuecomment-5606195969
Thanks for catching the contradiction in the generated compatibility page, and for rechecking the classifier. I addressed this in `afa8823ff`. This change only affects generated documentation and its test coverage; it does not change regex routing, the scanner, or the native kernel. `hasConditionalNativeDefault` is now documentation metadata on `NativeOptInAvailable` for expressions where some compatible cases run natively by default, while the remaining applicable cases retain the JVM-default/native-opt-in behavior. `CometRLike` uses this form. The generated `RLike` page now distinguishes the two routes: - `UTF8_BINARY` literal patterns admitted by the plan-time analyzer run natively by default. - Other applicable literal patterns use Spark's JVM codegen dispatcher by default, with an explicit native opt-in. `getIncompatibleReasons()` is scoped to those remaining applicable literals. The automatic-native note is rendered under “The following cases use Comet's native implementation by default”, rather than under the heading for differences that are always present. `GenerateDocsSuite` covers the conditional-native `RLike` output, including the config key; unchanged output for an ordinary native-opt-in expression; and unchanged headings for ordinary expressions. `GenerateDocsSuite` passes locally, and `python3 dev/ci/check-suites.py` passes with the suite registered in both the Linux and macOS PR workflows. I generated the latest compatibility pages for Spark 3.4, 3.5, 4.0, and 4.1. The unconditional “By default, RLike is evaluated in the JVM” sentence no longer appears in the latest pages. Historical release documentation remains unchanged. Outside the `RLike` sections, the generated output was byte-for-byte unchanged. Separately, I filed the deferred items from the earlier review: - Grammar-based differential fuzzing: #5811 - Representative whitelist admission-rate measurement: #5812 - Rust-side Java-generated parity fixtures for `regex` crate upgrades: #5813 Please take another look when you have a chance. Thanks again!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
