adriangb opened a new pull request, #25093: URL: https://github.com/apache/datafusion/pull/25093
> [!NOTE] > **Benchmark-only draft. Do not review or merge.** This exists so the benchmark bot has a buildable `changed` side for https://github.com/apache/datafusion/pull/21621. I will close it once the runs finish. ## Which issue does this PR close? - Related to https://github.com/apache/datafusion/issues/11900 and https://github.com/apache/datafusion/pull/21621. Closes nothing. ## Rationale for this change https://github.com/apache/datafusion/pull/21621 is 289 commits behind `main`, conflicts in `benchmarks/src/bin/dfbench.rs`, and its head no longer compiles the `datafusion-benchmarks` crate (`push_down_topk.rs:188` calls `print_memory_stats()` with no argument). The benchmark bot builds `dfbench` on the PR head, so triggering benchmarks on that PR fails on the `changed` side, and custom refs must be reachable from `apache/datafusion`. This branch is current `main` plus exactly the optimizer change from that PR, so `run benchmarks` here compares `main` against the rule with the `push_down_topk` suite from https://github.com/apache/datafusion/pull/22760 present on both sides. ## What changes are included in this PR? Merge of https://github.com/apache/datafusion/pull/21621 onto `main`, touching only: - `datafusion/optimizer/src/push_down_limit.rs` - `datafusion/optimizer/src/push_down_limit/topk_through_join.rs` - `datafusion/core/src/optimizer_rule_reference.md` - `datafusion/sqllogictest/test_files/push_down_topk_through_join.slt` The PR's duplicate `dfbench push-down-topk` subcommand and `benchmarks/queries/push_down_topk/*.sql` are dropped; the `sql_benchmarks/push_down_topk` suite already on `main` supersedes them. ## What is the testing strategy for this PR? None beyond the tests carried over from the source PR. Not for merge. ## Are there any user-facing changes? No. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
