andygrove commented on PR #5610: URL: https://github.com/apache/datafusion-comet/pull/5610#issuecomment-5607449719
Good catch, thanks. Regenerated in a66c196bc. I ran the base tier first, `SPARK_GENERATE_GOLDEN_FILES=1` against `-Pspark-3.4` for both `CometTPCDSV1_4_PlanStabilitySuite` and `CometTPCDSV2_7_PlanStabilitySuite`, since 3.4 is the only profile whose `planNameChain` resolves straight to `approved-plans-vX_Y` and therefore writes the shared base rather than a version-suffixed directory. v2_7's q78 came out with exactly the list you predicted: ``` - +- CometProject [COMET-INFO: JVM codegen dispatcher: round] + +- CometProject [COMET-INFO: JVM codegen dispatcher: add, cast, coalesce, divide, knownfloatingpointnormalized, normalizenanandzero, round] -...Accelerated expressions: 12 native, 1 codegen dispatch. +...Accelerated expressions: 12 native, 7 codegen dispatch. ``` v1_4's q78 needed the same update and was not in your report. It records the dispatcher on two operators rather than one, and `CometTakeOrderedAndProject` picks up the shorter `add, cast, coalesce, divide, round` because the normalization pair only appears under the project. Worth knowing that the V1_4 suite fails on this too. Then I re-ran both suites with regeneration on 3.5, 4.0, 4.1 and 4.2 to check whether any of them now diverges from the base and needs its own `approved-plans-*-sparkX_Y/q78` directory. All eight runs passed and the working tree came back with only those two base files modified, so `pruneDuplicateQueryDirs` removed nothing and added nothing: the expanded list is version-independent, as your five identical failures suggested. No other query moved, which is also the answer to whether recording descendants changes any golden beyond q78 — q24, q24a and q24b are the only other plans carrying a dispatcher line and none of them shifted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
