github-actions[bot] commented on PR #25053: URL: https://github.com/apache/datafusion/pull/25053#issuecomment-5611753602
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 39.122s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.025s] (current) Building datafusion v55.0.0 (baseline) Built [ 39.006s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.429s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 80.468s] datafusion Building datafusion-physical-expr v55.0.0 (current) Built [ 19.567s] (current) Parsing datafusion-physical-expr v55.0.0 (current) Parsed [ 0.035s] (current) Building datafusion-physical-expr v55.0.0 (baseline) Built [ 19.336s] (baseline) Parsing datafusion-physical-expr v55.0.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.240s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_physical_expr::equivalence::join_equivalence_properties now takes 8 parameters instead of 7, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/equivalence/properties/joins.rs:29 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 40.091s] datafusion-physical-expr Building datafusion-physical-plan v55.0.0 (current) Built [ 25.512s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.111s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 25.530s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.108s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.493s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 52.780s] datafusion-physical-plan Building datafusion-sqllogictest v55.0.0 (current) Built [ 66.857s] (current) Parsing datafusion-sqllogictest v55.0.0 (current) Parsed [ 0.017s] (current) Building datafusion-sqllogictest v55.0.0 (baseline) Built [ 67.690s] (baseline) Parsing datafusion-sqllogictest v55.0.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-sqllogictest v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.064s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 136.674s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
