viirya commented on code in PR #12090: URL: https://github.com/apache/datafusion/pull/12090#discussion_r1723900497
########## datafusion/sqllogictest/test_files/sort_merge_join.slt: ########## @@ -134,7 +134,6 @@ Alice 100 NULL NULL Alice 50 Alice 2 Bob 1 NULL NULL NULL NULL Alice 1 -NULL NULL Alice 2 Review Comment: This is incorrect. `Alice 2` was joined with `Alice 50` above. We should not produce null join row for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
