comphead commented on code in PR #12090:
URL: https://github.com/apache/datafusion/pull/12090#discussion_r1724059850
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -596,7 +596,7 @@ struct BufferedBatch {
pub size_estimation: usize,
/// The indices of buffered batch that failed the join filter.
/// When dequeuing the buffered batch, we need to produce null joined rows
for these indices.
- pub join_filter_failed_idxs: HashSet<u64>,
+ pub join_filter_failed_map: HashMap<u64, bool>,
Review Comment:
Please comment what is key and value in the map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
