aoto-tech commented on PR #25074: URL: https://github.com/apache/datafusion/pull/25074#issuecomment-5615413287
@kumarUjjawal san Thanks for the review. I’ve pushed updates addressing both comments: * Kept the filter input intact, including Projection and SubqueryAlias. Different computed projections remain separate, while identical ones over the same source can still be merged. * Added recursive checks for volatile expressions and subqueries throughout the retained source. * Simplified the other arm to use other directly and removed strip_passthrough_nodes, including the redundant check and unreachable debug message. * Added optimizer unit tests and SQL regression tests covering computed projections and aliases, with the rewrite both enabled and disabled in the SQL tests. Regarding the source-identity concern I mentioned earlier, GroupKey now also checks the corresponding TableSource instances using Arc::ptr_eq, since TableScan equality ignores source. This conservatively prevents distinct source instances with identical scan metadata from being merged. I added regression tests for both direct scans and scans nested below projections and aliases. I also used unwrap() instead of ? in the newly added tests to address a CI coverage issue: when using ?, coverage was silently missed without an explicit error. Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
