alamb commented on code in PR #24715: URL: https://github.com/apache/datafusion/pull/24715#discussion_r3978376698
########## datafusion/sql/src/statement.rs: ########## Review Comment: Would it be possible to look into putting this check in the optimizer that has the requirement instead of the SQL planner, as suggested here https://github.com/apache/datafusion/issues/24701#issuecomment-5428054288 ? There is no reason in general Datafusion can't plan such queries, it is only if that optimizer pass is invoked (so I think the error should live in the optimizer pass) Also, can you please add .slt tests (not just unit tests)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
