alamb commented on issue #12089: URL: https://github.com/apache/datafusion/issues/12089#issuecomment-2299690406
I suggest a fourth option: 1. ignore a cancelled task (with comments about why) as it can only happen when the runtime is shutting down Calling `unreachable` doesn't do any good in this case because it simply causes some thread to panic but that panic will not propagate to the main thread (as it is happening during a runtime shutdown anyways) @DDtKey and @devinjdangelo for your thoughts I believe you added the code in question as part of https://github.com/apache/datafusion/pull/9422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
