crepererum commented on issue #12089: URL: https://github.com/apache/datafusion/issues/12089#issuecomment-2301452144
I totally see the use case for `join_unwind` though: it resumes unwinding on another thread, which often simplifies debugging a lot. Yeeting through logs and errors that just say "some thread panicked" without an actual backtrace isn't much fun (based on personal experience). So I think we should keep that API, but make it fallible: - return `OK(...)` if the underlying task returned cleanly - panic if the underlying task panicked - return `Err(...)` if the underlying task couldn't be completed due to system reasons (which in the current tokio setup is always a runtime shutdown) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
