dwsmith1983 commented on issue #2855: URL: https://github.com/apache/datafusion-comet/issues/2855#issuecomment-5637786997
The native `spark_modulo` now raises Spark's `REMAINDER_BY_ZERO` error: native/spark-expr/src/math_funcs/modulo_expr.rs maps Arrow's `DivideByZero` from the remainder kernel to `remainder_by_zero_error()`, the message and error class are defined in native/common/src/error.rs, and the unit test in modulo_expr.rs asserts the `[REMAINDER_BY_ZERO] Remainder by zero` text. #4253 (22b7bed1a) re-enabled the Spark 4.1 tests that were skipped waiting on this. Suggest closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
