Rachelint commented on code in PR #11943:
URL: https://github.com/apache/datafusion/pull/11943#discussion_r1724904571
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -509,6 +523,15 @@ impl GroupedHashAggregateStream {
None
};
+ // Check if we can enable the blocked optimization for `GroupValues`
and `GroupsAccumulator`s.
+ let enable_blocked_group_states = maybe_enable_blocked_group_states(
+ &context,
+ group_values.as_mut(),
+ &mut accumulators,
+ batch_size,
Review Comment:
> One thing to do is expose block size as a different configuration knob,
and also find a good default value (Now it's using the same as batch size)
🤔 I think the `batch_size` is better equal to `n * block_size`? Otherwise,
we need to `slice` it before emitting to next operator, and the `slice` is a
actually a bit expansive.
Maybe we should consider how to expose the config option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
