mbutrovich commented on code in PR #5853:
URL: https://github.com/apache/datafusion-comet/pull/5853#discussion_r3992926045
##########
native/proto/src/proto/operator.proto:
##########
@@ -407,14 +414,24 @@ message IcebergDeleteFile {
// Equality field IDs (empty for positional deletes)
repeated int32 equality_ids = 4;
- // Fields 5-7 are reserved for the deletion-vector coordinates on the
dv-read branch
- // (referenced_data_file / content_offset / content_size_in_bytes) so the
two features can merge
- // in either order without a tag collision.
- reserved 5, 6, 7;
+ // Deletion vector coordinates, set only for V3 deletion vectors.
referenced_data_file is the
+ // data file the vector applies to; content_offset and content_size_in_bytes
locate the
+ // deletion-vector-v1 blob within its Puffin file.
+ optional string referenced_data_file = 5;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
