Blizzara commented on code in PR #12098:
URL: https://github.com/apache/datafusion/pull/12098#discussion_r1725125980
##########
datafusion/expr/src/udaf.rs:
##########
@@ -442,7 +442,7 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
/// not implement the method, returns an error. Order insensitive and hard
/// requirement aggregators return `Ok(None)`.
fn with_beneficial_ordering(
- self: Arc<Self>,
+ &self,
Review Comment:
The `Arc<Self>` was hard to call from the aliased version. Is there a reason
why it was Arc'd?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
