Blizzara commented on code in PR #12098: URL: https://github.com/apache/datafusion/pull/12098#discussion_r1726751837
########## datafusion/expr/src/udaf.rs: ########## @@ -442,7 +442,7 @@ pub trait AggregateUDFImpl: Debug + Send + Sync { /// not implement the method, returns an error. Order insensitive and hard /// requirement aggregators return `Ok(None)`. fn with_beneficial_ordering( - self: Arc<Self>, + &self, Review Comment: Hmm, dunno if there is a difference between passing an Arc<Self> and &self perf wise - neither should require copy. But I got it work with the Arc<> (by adding a .clone() there, but that should only clone the pointer and not the self so I think that's fine as well), so then I don't need to change this and that's probably safer 😅 fixed in https://github.com/apache/datafusion/pull/12098/commits/33b89ceb3eb69e9b206121b883011bd85ea56b7e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org