rich7420 opened a new pull request, #5856: URL: https://github.com/apache/datafusion-comet/pull/5856
## Which issue does this PR close? Part of #5212. ## Rationale for this change The existing `CometTaskMemoryManagerSuite` test uses one manager whose requests are fully granted. It cannot catch accounting requested bytes instead of granted bytes, or reporting the task total as a manager's own usage. ## What changes are included in this PR? Add tests for partial and zero grants, release and reacquisition, and separate balances for two managers sharing a task. Assert manager usage, Spark consumer usage and the task total throughout. Extract the existing task setup into a helper that clears the task context even if cleanup fails. ## How are these changes tested? All three suite tests pass through the root Maven reactor on Spark 4.1.3 / JDK 21. Two mutation checks confirm the new tests catch the accounting errors above while the original test passes. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34422279174) passes, including Linux Spark 3.4–4.2 and macOS Spark 4.0. These tests cover JVM accounting with Spark's `TestMemoryManager`; they do not exercise JNI or native pool rollback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
