goldmedal commented on code in PR #12046:
URL: https://github.com/apache/datafusion/pull/12046#discussion_r1725272486
##########
datafusion/sql/src/select.rs:
##########
@@ -766,9 +769,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
check_columns_satisfy_exprs(
Review Comment:
I think the function can be shared. The difference is that the check of
`having` requires a return value to confirm that the validation has been
executed and is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
