comphead commented on code in PR #12027: URL: https://github.com/apache/datafusion/pull/12027#discussion_r1725372709
########## datafusion/functions/src/string/common.rs: ########## @@ -252,7 +254,69 @@ impl<'a> ColumnarValueRef<'a> { } } +/// Abstracts iteration over different types of string arrays. +/// +/// This trait helps write generic code for string functions that can work with Review Comment: ```suggestion /// The [`StringArrayType`] trait helps write generic code for string functions that can work with ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org