alamb commented on PR #12027: URL: https://github.com/apache/datafusion/pull/12027#issuecomment-2302777907
@Omega359 and @XiangpengHao -- what do you think we should do with the conversation above? https://github.com/apache/datafusion/pull/12027#issuecomment-2295332991 I can't tell if we are suggesting we go with the `StringArrays` approach or if the `StringArrayType` trait is ok? My "gut" feel is the same as @XiangpengHao that implementing using generics (not `dyn StringArrayType` but a function that is generic over `StringArrayType` should be at least as fast as the "dynamic dispatch" mechanism of `StringArray`s (because the compiler gets a change to build special code for it) The downside of the generics approach is that now we'll end up with 3 copies of most functions and the extra performance, if any, may not justify the binary overhead 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
