github-actions[bot] commented on PR #25257: URL: https://github.com/apache/datafusion/pull/25257#issuecomment-5652389820
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 42.429s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.024s] (current) Building datafusion v55.0.0 (baseline) Built [ 37.990s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.391s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 82.407s] datafusion Building datafusion-physical-optimizer v55.0.0 (current) Built [ 25.916s] (current) Parsing datafusion-physical-optimizer v55.0.0 (current) Parsed [ 0.015s] (current) Building datafusion-physical-optimizer v55.0.0 (baseline) Built [ 26.308s] (baseline) Parsing datafusion-physical-optimizer v55.0.0 (baseline) Parsed [ 0.015s] (baseline) Checking datafusion-physical-optimizer v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.072s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 53.201s] datafusion-physical-optimizer Building datafusion-physical-plan v55.0.0 (current) Built [ 24.255s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.107s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 24.044s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.106s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.464s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure type_method_marked_deprecated: type method #[deprecated] added --- Description: A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/type_method_marked_deprecated.ron Failed in: method datafusion_physical_plan::aggregates::AggregateExec::with_new_limit_options in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/mod.rs:946 method datafusion_physical_plan::aggregates::AggregateExec::with_limit_options in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/mod.rs:973 method datafusion_physical_plan::aggregates::AggregateExec::limit_options in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/mod.rs:986 Summary semver requires new minor version: 0 major and 1 minor checks failed Finished [ 50.262s] datafusion-physical-plan Building datafusion-proto v55.0.0 (current) Built [ 34.914s] (current) Parsing datafusion-proto v55.0.0 (current) Parsed [ 0.011s] (current) Building datafusion-proto v55.0.0 (baseline) Built [ 35.213s] (baseline) Parsing datafusion-proto v55.0.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-proto v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.074s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 71.417s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
