Satyr09 commented on code in PR #5789: URL: https://github.com/apache/datafusion-comet/pull/5789#discussion_r3999290770
########## docs/source/contributor-guide/expression-audits/datetime_funcs.md: ########## @@ -95,4 +95,12 @@ - Rewrites to `Cast(..., EvalMode.LEGACY)` (no format, native) or `GetTimestamp(..., failOnError = false)` (with format, via the codegen dispatcher) before Comet sees the plan. In non-ANSI mode the rewritten tree is identical to `to_timestamp`; invalid inputs return NULL to match Spark. +## unix_timestamp + +- Spark 3.4.3 (audited 2026-09-09): string input uses Spark's generated parser through codegen dispatch. Literal and column formats preserve null handling, ANSI errors, parser policy, and session time zone. Review Comment: Yeah that makes sense to me. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
