Satyr09 commented on code in PR #5789:
URL: https://github.com/apache/datafusion-comet/pull/5789#discussion_r3999318697
##########
spark/src/main/scala/org/apache/comet/serde/datetime.scala:
##########
@@ -290,12 +290,14 @@ private[serde] object DatetimeCollation extends
CometTypeShim {
expr.children.exists(c => hasNonDefaultStringCollation(c.dataType))
}
-object CometUnixTimestamp extends CometExpressionSerde[UnixTimestamp] {
+object CometUnixTimestamp
+ extends CometExpressionSerde[UnixTimestamp]
+ with CodegenDispatchFallback {
private val collationReason = DatetimeCollation.reason("unix_timestamp")
override def getUnsupportedReasons(): Seq[String] = Seq(
- "Only `DateType`, `TimestampType`, and `TimestampNTZType` inputs are
supported.")
+ "Native execution only supports `DateType`, `TimestampType`, and
`TimestampNTZType` inputs.")
override def getIncompatibleReasons(): Seq[String] =
DatetimeCollation.incompatibleReasons("unix_timestamp")
Review Comment:
Good catch!
Fixed - the timestamp/date types with a collate attached now execute
natively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
