athlcode commented on PR #5876: URL: https://github.com/apache/datafusion-comet/pull/5876#issuecomment-5653949692
> One more thing I missed on the first pass. The new `strict-scala-warnings` job goes straight to `./mvnw` with no `Bootstrap Maven` step. Every other job in `pr_build_linux.yml` that calls `./mvnw` directly now uses `./.github/actions/maven-bootstrap` first, added by #5852, and the workflows README says any job whose first Maven use is a bare `./mvnw` needs it. Without it a blip fetching the Maven distribution fails the job before anything compiles, and since this rolls up into `Required Checks` that evicts the PR from the merge queue. Could you add the step between the cache restore and the compile? @andygrove sorry I forgot to push those changes, have pushed it now, please do review, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
