athlcode commented on PR #5876: URL: https://github.com/apache/datafusion-comet/pull/5876#issuecomment-5653975225
> The new job comment says the Scala 2.13 remainder is tracked separately, but I could not find an issue for it. Searching open and closed issues turns up only #2255, which this PR closes. The POM comment it points at also just says the 2.13 warnings are left for a follow-up. That leaves the profile usable on 2.12 only, CI enforcing one profile, and the remaining 2.13 warnings with nothing recording them. Could you open an issue for the `-Xlint:nonlocal-return` and non-exhaustive-match work and link it from both this comment and the POM? > > On the POM comment, I think we still have the drift problem I raised earlier. The value-discard counts are gone, but the unused-params paragraph still says `~90-120 parameters per profile` and `64 @native declarations`, and those were two of the numbers I was worried about. Both go stale the moment someone adds a `@native` declaration or a shim. Could we drop them and keep just the reasoning about `Native.scala` and the cross-version shims? > > Separately, I went looking for a silent behavior change behind any of these warning fixes and did not find one, which is the main risk with a change this mechanical. The `private[shuffle]` additions still leave public classes and constructors in bytecode so Spark's reflective `spark.shuffle.manager` instantiation resolves, every `val _ =` site sits in a method already declared `Unit`, the removed default arguments are supplied explicitly at every call site, and the removed helpers have no remaining references. @andygrove I have opened an issue for the `-Xlint:nonlocal-return` and non-exhaustive-match work and link it from both this comment and the POM: https://github.com/apache/datafusion-comet/issues/5893 please let me know if I need to any more information in the issue or you can add as well thank you Forgot to push latest changes, I have pushed the changes to drop the `~90-120 parameters per profile` and `64 @native declarations` now, please do review and thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
