NikitaMatskevich commented on code in PR #5724: URL: https://github.com/apache/datafusion-comet/pull/5724#discussion_r4000963617
##########
docs/source/user-guide/latest/iceberg-writes.md:
##########
@@ -154,7 +154,9 @@ A write is eligible only when ALL of the following hold:
| `write.parquet.page-version`
| unset or `v1`
|
| `write.parquet.shred-variants`
| unset or
`false` (Spark 4.x / Iceberg 1.11 resolve this into every parquet write)
|
| `write.parquet.variant-inference-buffer-size`
| any value
(only meaningful when shredding, which is gated)
|
-| `write.parquet.bloom-filter-enabled.column.<col>`
| unset or
`false`
|
+| `write.parquet.bloom-filter-enabled.column.<col>`
| `true` or
`false`; an explicit NDV enables the column even when this value is `false`,
matching Iceberg's property application order
|
+| `write.parquet.bloom-filter-fpp.column.<col>` /
`write.parquet.bloom-filter-ndv.column.<col>`
| For every column named by an `enabled` property, FPP must be a
finite double strictly between 0 and 1 and NDV must be a positive Java long no
greater than `Long.MAX_VALUE / 8`; the Iceberg FPP default is `0.01`
|
Review Comment:
Fixed in commit `docs: describe Parquet 59 bloom folding`. The documentation
now states which Iceberg runtime versions interpret the per-column FPP and NDV
properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
