alamb commented on code in PR #11597:
URL: https://github.com/apache/datafusion/pull/11597#discussion_r1725673494
##########
datafusion/substrait/Cargo.toml:
##########
@@ -38,9 +38,9 @@ chrono = { workspace = true }
datafusion = { workspace = true, default-features = true }
itertools = { workspace = true }
object_store = { workspace = true }
-pbjson-types = "0.6"
-prost = "0.12"
-substrait = { version = "0.36.0", features = ["serde"] }
+pbjson-types = "0.7"
+prost = "0.13"
+substrait = { version = "0.41", features = ["serde"] }
Review Comment:
Thanks @Blizzara
I also have a PR prepared to update a bunch of these dependencies as well
queued up for the arrow release next week:
https://github.com/apache/datafusion/pull/12032
##########
datafusion/substrait/src/variation_const.rs:
##########
@@ -38,10 +38,16 @@
/// The "system-preferred" variation (i.e., no variation).
pub const DEFAULT_TYPE_VARIATION_REF: u32 = 0;
pub const UNSIGNED_INTEGER_TYPE_VARIATION_REF: u32 = 1;
+
+#[deprecated(since = "41.0.0", note = "Use `PrecisionTimestamp(Tz)` type
instead")]
Review Comment:
SInce we have already released `41`
https://crates.io/crates/datafusion/41.0.0 I think we should probably label
this with the next version. For example:
```suggestion
#[deprecated(since = "42.0.0", note = "Use `PrecisionTimestamp(Tz)` type
instead")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
