Blizzara commented on code in PR #11597:
URL: https://github.com/apache/datafusion/pull/11597#discussion_r1723434757
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -2332,35 +2363,4 @@ mod test {
assert_eq!(dt, roundtrip_dt);
Ok(())
}
-
- #[test]
- fn custom_type_extensions() -> Result<()> {
Review Comment:
see above - we no longer produce custom types
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -2225,39 +2285,6 @@ mod test {
Ok(())
}
- #[test]
- fn custom_type_literal_extensions() -> Result<()> {
Review Comment:
As we no longer produce user-defined types for any scalars or types, this
test and the one below don't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
