goutamadwant commented on code in PR #25009:
URL: https://github.com/apache/datafusion/pull/25009#discussion_r4002707877
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -673,20 +673,25 @@ impl ExecutionPlan for ProjectionExec {
metrics: _,
// Derived plan properties, recomputed on decode.
cache: _,
- // Derived metadata comparison, recomputed with the projector.
- overrides_metadata: _,
+ overrides_metadata,
} = self;
let projection_exprs = projector.projection().as_ref();
let input = ctx.encode_child(input)?;
let expr = ctx.encode_expressions(projection_exprs.iter().map(|p|
&p.expr))?;
let expr_name = projection_exprs.iter().map(|p|
p.alias.clone()).collect();
+ let schema = if *overrides_metadata {
Review Comment:
@gene-bordegaray Updated the condition to encode schema or output-field
metadata even when inherited. The override check remains so an empty metadata
map can still explicitly clear input metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
