namanjain24-sudo commented on PR #25045: URL: https://github.com/apache/datafusion/pull/25045#issuecomment-5661168950
Thanks, f86799b covers both points. The comment now says Substrait defines `UNSPECIFIED` as `INTERMEDIATE_TO_RESULT`, and that the exception also lets through other producers' intermediate-state calls, which can't be told apart here. That definition reads the same in the pinned `substrait` 0.63.0 crate and on substrait `main`. I also merged the branch onto current `main` (c2cf289) locally: no conflicts, `cargo fmt` and `cargo clippy -D warnings` are clean, and `substrait_integration` passes (214 passed, 6 ignored), including the 7 `aggregation_tests`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
