comphead commented on code in PR #553: URL: https://github.com/apache/datafusion-comet/pull/553#discussion_r1725752744
########## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ########## @@ -2860,7 +2860,11 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim case RightOuter => JoinType.RightOuter case FullOuter => JoinType.FullOuter case LeftSemi => JoinType.LeftSemi - case LeftAnti => JoinType.LeftAnti + // TODO: DF SMJ with join condition fails TPCH q21 Review Comment: let me have a look on q21. I remember Anti join had issues with TPCH in DF but it was fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org