viirya commented on code in PR #553: URL: https://github.com/apache/datafusion-comet/pull/553#discussion_r1730694991
########## spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala: ########## @@ -75,7 +75,6 @@ abstract class CometTestBase conf.set(MEMORY_OFFHEAP_SIZE.key, "2g") conf.set(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key, "1g") conf.set(SQLConf.ADAPTIVE_AUTO_BROADCASTJOIN_THRESHOLD.key, "1g") - conf.set(SQLConf.COALESCE_PARTITIONS_ENABLED.key, "false") Review Comment: We don't need to set `SQLConf.COALESCE_PARTITIONS_ENABLED.key` false now. We also need to remove this to trigger test failure https://github.com/apache/datafusion-comet/pull/553/files#r1730694210. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org