neilconway commented on PR #23922: URL: https://github.com/apache/datafusion/pull/23922#issuecomment-5666014471
@rluvaton For example: * Describe the behavior change (`factorial` now implements `output_ordering`), and clearly enumerate the documentation-only changes (e.g., list the functions that got doc updates and why) * "marked if something is order preserving or not" -> this is imprecise for the current version of the PR, aswe only mark things as not-order-preserving * "Are these changes tested: No" -- I would hope that is not accurate :) As it happens we do update the tests in this PR. etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
