timsaucer commented on code in PR #1716:
URL:
https://github.com/apache/datafusion-python/pull/1716#discussion_r4008095275
##########
docs/source/user-guide/data-sources.md:
##########
@@ -120,6 +125,28 @@ ctx.register_parquet("trips", path)
ctx.table("trips").show()
```
+### Use S3 in SQL
+
+Configure S3 access on an {py:class}`~datafusion.object_store.AmazonS3` object
and
+register it on the context before issuing SQL that uses an `s3://` location.
AWS
+credentials are not SQL `OPTIONS`: `aws.*` is not a recognized SQL
configuration
+namespace.
Review Comment:
This text is confusing. It reads as if it is answering a question in the
issue rather than being user facing. There is no reason to think that `aws.*`
would be a configuration namespace per se.
##########
docs/source/user-guide/data-sources.md:
##########
@@ -100,11 +100,16 @@ Supported Object Stores are
- {py:class}`~datafusion.object_store.MicrosoftAzure`
```python
+import os
Review Comment:
why import `os`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
