emecii commented on code in PR #1716:
URL:
https://github.com/apache/datafusion-python/pull/1716#discussion_r4008781457
##########
docs/source/user-guide/data-sources.md:
##########
@@ -120,6 +125,28 @@ ctx.register_parquet("trips", path)
ctx.table("trips").show()
```
+### Use S3 in SQL
+
+Configure S3 access on an {py:class}`~datafusion.object_store.AmazonS3` object
and
+register it on the context before issuing SQL that uses an `s3://` location.
AWS
+credentials are not SQL `OPTIONS`: `aws.*` is not a recognized SQL
configuration
+namespace.
Review Comment:
Rewritten in 0d0a29e to explain creating and querying a table through the
registered bucket store. Removed the namespace/error discussion from the guide
and the #970 closure claim from the PR description.
##########
docs/source/user-guide/data-sources.md:
##########
@@ -100,11 +100,16 @@ Supported Object Stores are
- {py:class}`~datafusion.object_store.MicrosoftAzure`
```python
+import os
Review Comment:
It supported the two os.getenv calls in that example. Simplified this in
0d0a29e: AmazonS3 already reads environment configuration, so the import and
both calls are removed; the required environment variables are stated above the
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
