quwin commented on PR #25039:
URL: https://github.com/apache/datafusion/pull/25039#issuecomment-5671976531
Thanks for the review @jayzhan211,
I've extracted `validate_function_body_placeholders` and walked subqueries
with `apply_with_subqueries` + `apply_expressions` as you suggested, covering
`ScalarSubquery`, `Exists`, `InSubquery`, and `SetComparison`.
As a follow-up, I found a second gap, where argument `DEFAULT` expressions
are planned permissively and spliced into the body at call time, so `DEFAULT
$9` also slipped through. They're now validated with the same rule.
For tests, they now cover subquery forms, nesting two levels deep, subquery
`ORDER BY`/ `LIMIT`, defaults, and positive cases; `.slt` asserts the
definition-time errors.
Could you re-run CI and take a look at the updated head? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
