sunchao commented on PR #5841: URL: https://github.com/apache/datafusion-comet/pull/5841#issuecomment-5672837471
@andygrove, both items from your latest review are addressed. Rebased onto `main` at `39da85081`; the new head is `a126925b7` and GitHub reports no merge conflicts. 1. **JDK 17:** carried the Spark 3.4/JDK 17 lint matrix entry and unconditional `JAVA_TOOL_OPTIONS` into `pr_build_linux_checks.yml`. The preflight, Spark 3.4, Iceberg 1.8, and Linux test updates from #5897 are also preserved. All six moved jobs match the current upstream jobs. 2. **Contributor guide:** the compile-only instructions now point to `pr_build_linux_checks.yml`. The suite-matrix instructions still point to `pr_build_linux.yml`, where `linux-test` remains. The rebase also preserves Spark 3.4's new label/manual-only policy. Updated the selection regression to verify that queue runs select the other eight consumers, that a Spark 3.4-only queue change does not start native compilation, and that labels cannot opt Spark 3.4 back into a queue run. Its label and manual paths remain covered through both Python and the CLI. Local checks passed: 36 configuration tests, 21 selection tests (including 299,008 combinations), actionlint, suite/benchmark checks, 15 Iceberg shard tests, 4 PR-label tests, Markdown formatting, and whitespace checks. Updated the PR description with the previous green coverage and the [fresh CI run](https://github.com/apache/datafusion-comet/actions/runs/34913499387). The four opt-in labels remain applied; results on this rebased head are pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
