sunchao commented on PR #5841: URL: https://github.com/apache/datafusion-comet/pull/5841#issuecomment-5691848650
@andygrove, all items in your latest review are addressed in `3c31e5aa8`. I checked the current head against the review and reran the configuration and routing tests. - Both Linux callers pass the same `cache-refresh-only` and `profiles` inputs. In cache-refresh mode, the four moved Java/Scala lint, compile-only, and Celeborn jobs are skipped, while Rust formatting and the Rust debug cache writer remain active. The Linux JVM test matrix is also guarded. The expressions account for the newer all-profile/nightly route. - `CACHE_REFRESH_JOBS` now maps each of the three workflows to its retained jobs and reasons. Each Linux caller's inputs are checked independently. Mutation tests cover a dropped guard in the checks workflow, missing/miswired inputs on either caller, and removing or guarding off the cache writers and their prerequisites. - The contributor CI guide now explains cache ownership across the three files and where new jobs need guards. The `build_linux` policy comment explicitly explains why push must select all three workflows. The earlier Maven bootstrap, Hive routing, JDK 17, and compile-job documentation fixes remain present. The configuration checker, all 41 configuration tests, and all 23 selection tests pass. Both [commit CI](https://github.com/apache/datafusion-comet/actions/runs/35040404817) and [Spark 4.1 opt-in CI](https://github.com/apache/datafusion-comet/actions/runs/35040413280) passed on this exact head. Together they exercised all nine native consumers, including every Spark 4.1 Hive shard. Hosted push/nightly execution remains separate from this PR coverage; their selection and guards are covered locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
