alamb commented on issue #25100: URL: https://github.com/apache/datafusion/issues/25100#issuecomment-5681576599
I guess what I am saying is that if the goal is to ensure that datafusion produced plans can be consumed by substrait-java, we should be testing that explicitly somehow (and not one offs in an issue comment). Otherwise I predict it will be hard to find people who can review / look at these PRs and both 1) Have confidence they match the java behavior, 2) will continue to work over time For example, can we make a test that makes DataFusion plans, and then tries to consume it using substrait-java? We could perhaps only run this test on changes to datafusion-substrait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
