alamb commented on PR #2497: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2497#issuecomment-5687182218
> But a PNG cannot be expanded, defeating a bit the purpose of having the flamegraph in the first place. Is this done solely because of the licensing issue? Yes -- but note the png is only used for the docs (for instructions on how to create a full svg) Another thing we could do would be to keep the svg and exclude it from the packaging in create_tarball.sh 🤔 I can do that if you prefer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![Re: [PR] Replace benchmark flamegraph.svg with png [datafusion-sqlparser-rs]](/search?l=github@datafusion.apache.org&q=subject:%22Re%5C%3A+%5C%5BPR%5C%5D+Replace+benchmark+flamegraph.svg+with+png+%5C%5Bdatafusion%5C-sqlparser%5C-rs%5C%5D%22&o=newest){kind=link}
