Copilot commented on code in PR #25245:
URL: https://github.com/apache/datafusion/pull/25245#discussion_r4019756081
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -45,6 +47,12 @@ pub struct FFI_PlanProperties {
/// Indicate boundedness of the plan and its memory requirements.
pub boundedness: unsafe extern "C" fn(plan: &Self) -> FFI_Boundedness,
+ /// Return the scheduling type of the plan.
+ pub scheduling_type: unsafe extern "C" fn(plan: &Self) ->
FFI_SchedulingType,
+
+ /// Return the evaluation type of the plan.
+ pub evaluation_type: unsafe extern "C" fn(plan: &Self) ->
FFI_EvaluationType,
Review Comment:
These fields change the size and offsets of the `#[repr(C)]
FFI_PlanProperties`, but the FFI major version remains 55 (`Cargo.toml` is
55.1.0 and `version()` derives its major). A consumer built against the
existing 55.x ABI can therefore treat this layout as compatible even though the
by-value `properties` return no longer has the same ABI, leading to invalid
callback reads or ABI corruption. Please land this only with the corresponding
major-version compatibility gate and rebuild requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
