timsaucer commented on code in PR #25245:
URL: https://github.com/apache/datafusion/pull/25245#discussion_r4019755826
##########
datafusion/ffi/src/execution_plan.rs:
##########
@@ -595,6 +595,22 @@ pub mod tests {
self
}
+ pub fn with_scheduling_type(
+ mut self,
+ scheduling_type:
datafusion_physical_plan::execution_plan::SchedulingType,
+ ) -> Self {
+ Arc::make_mut(&mut self.props).scheduling_type = scheduling_type;
+ self
+ }
+
+ pub fn with_evaluation_type(
+ mut self,
+ evaluation_type:
datafusion_physical_plan::execution_plan::EvaluationType,
+ ) -> Self {
+ Arc::make_mut(&mut self.props).evaluation_type = evaluation_type;
+ self
+ }
Review Comment:
Was this all necessary? `EmptyExec` is just a test execution plan - is there
any reason not to just set those properties by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
