dwsmith1983 commented on PR #5874: URL: https://github.com/apache/datafusion-comet/pull/5874#issuecomment-5690488300
> Its payload labels need qualification: the generator uses decimal signed-Long text, producing variable widths and nine repeated values, rather than the reported fixed 8 B/1 KiB payloads, 10-character strings and five values. Corrected in the benchmark's doc comment and inline comment: the payloads are the decimal text of the generated Long, so `b_short` is up to 20 bytes wide, `b_long` is 128 repeats of it, `b_null` blanks one row in five, and `b_repeated` cycles through the nine values of `value % 5` over the signed generator; `c1` is that text repeated ten times. The measurements stand as posted, only their labels changed. Merged with `main` at 3868760f9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
