yashrb24 commented on code in PR #24993:
URL: https://github.com/apache/datafusion/pull/24993#discussion_r4026431733


##########
datafusion/execution/src/memory_pool/pool.rs:
##########
@@ -340,8 +340,9 @@ impl TrackedConsumer {
     /// Grows the tracked consumer's reserved size,
     /// should be called after the pool has successfully performed the grow().
     fn grow(&self, additional: usize) {

Review Comment:
   i've added this test, but it looks a bit too invasive in the sense that I've 
added some test-only fields in the configs. Do you have some suggestions on 
some other ways of getting this race reproduced via a test? Or does this look 
fine
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to