dwsmith1983 commented on code in PR #5872:
URL: https://github.com/apache/datafusion-comet/pull/5872#discussion_r4032137473
##########
docs/source/user-guide/latest/datasources.md:
##########
@@ -221,7 +221,8 @@ AWS credential providers can be configured using the
`fs.s3a.aws.credentials.pro
|
`com.amazonaws.auth.InstanceProfileCredentialsProvider`<br/>`software.amazon.awssdk.auth.credentials.InstanceProfileCredentialsProvider`
| Access S3 using EC2
instance metadata service (IMDS)
| None
|
|
`com.amazonaws.auth.ContainerCredentialsProvider`<br/>`software.amazon.awssdk.auth.credentials.ContainerCredentialsProvider`<br/>`com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper`
| Access S3 using ECS task credentials
| None
|
|
`com.amazonaws.auth.WebIdentityTokenCredentialsProvider`<br/>`software.amazon.awssdk.auth.credentials.WebIdentityTokenFileCredentialsProvider`
| Authenticate using web
identity token file
| None
|
-|
`com.amazonaws.auth.profile.ProfileCredentialsProvider`<br/>`software.amazon.awssdk.auth.credentials.ProfileCredentialsProvider`
| Authenticate
using a named profile from the local AWS credentials file
| None
|
+| `org.apache.hadoop.fs.s3a.auth.ProfileAWSCredentialsProvider`
| Authenticate using a named profile from the
local AWS credentials file |
`fs.s3a.auth.profile.name` (optional), `fs.s3a.auth.profile.file` (optional);
Hadoop applies both only to this provider |
+|
`com.amazonaws.auth.profile.ProfileCredentialsProvider`<br/>`software.amazon.awssdk.auth.credentials.ProfileCredentialsProvider`
| Authenticate
using the SDK's default profile; Hadoop constructs these without its
configuration, so the profile keys are not applied on either side | None
|
Review Comment:
> Could you run `prettier --write
docs/source/user-guide/latest/datasources.md` for this table change?
Done in 7b95c8f. `prettier --check "**/*.md"` with prettier 3.9.7 now passes
on the full tree, and the branch is merged with main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
