dwsmith1983 commented on code in PR #5872:
URL: https://github.com/apache/datafusion-comet/pull/5872#discussion_r4081256711
##########
native/core/src/parquet/objectstore/s3.rs:
##########
@@ -814,11 +882,22 @@ impl CredentialProviderMetadata {
.build();
Ok(Arc::new(credential_provider))
}
- CredentialProviderMetadata::Profile => {
- let credential_provider =
ProfileFileCredentialsProvider::builder()
- .configure(&ProviderConfig::with_default_region().await)
- .build();
- Ok(Arc::new(credential_provider))
+ CredentialProviderMetadata::Profile { name, file } => {
+ let mut builder = ProfileFileCredentialsProvider::builder()
+ .configure(&ProviderConfig::with_default_region().await);
+ if let Some(name) = name {
+ builder = builder.profile_name(name);
+ }
+ if let Some(file) = file {
Review Comment:
> Could we preserve Hadoop's file selection when `fs.s3a.auth.profile.file`
is unset too?
In 0c76e6c1a. The Hadoop profile provider arm reads only the credentials
file, from `fs.s3a.auth.profile.file`, then `AWS_SHARED_CREDENTIALS_FILE`, then
the default path, and never merges the config file, so the static identity wins
in your example on both sides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
