Smallfu666 commented on PR #5227: URL: https://github.com/apache/datafusion-comet/pull/5227#issuecomment-5711480085
Thanks again for the review, and sorry for the churn on this branch. I went back through your comments and reduced the PR to the parts that are directly relevant to the map cast fix. The unreachable sorted rejection is gone. The target sorted flag is simply preserved, and the fast path is limited to the rename-only case where neither child type changes. The tests now cover the sliced fast path, the hand-built path, and a direct comparison between the two. I also kept the field-count guard because the indexing happens before `try_new`, so without it malformed targets can still panic. While rechecking the surrounding behavior I found that the entries null buffer mentioned in #5097 does not appear to be representable through arrow's valid `MapArray` construction paths, so the PR body now documents that rather than claiming to preserve it. I also found a separate reachable `TRY_CAST` issue for narrowing integral map keys, filed as #5995. I am keeping that out of this PR rather than widening the scope again. The branch is now rebased on current main and the Rust tests, clippy, and fmt are clean. CI is still `action_required`, so if you have a chance to approve the workflow run, that should be the remaining step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
